Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to rubocop 0.35 #63

Merged
merged 1 commit into from
Apr 12, 2016
Merged

Update to rubocop 0.35 #63

merged 1 commit into from
Apr 12, 2016

Conversation

mr-salty
Copy link
Contributor

  • Fix newly introduced warnings (extra parens, variable case)
  • also remove a renundant required_ruby_version that crept in.

@mr-salty
Update to rubocop 0.35
a25a5c5 
* Fix newly introduced warnings (extra parens, variable case)
* also remove a renundant required_ruby_version that crept in.
@mr-salty
Copy link
Contributor Author

@laramiel PTAL. For some reason I started running into rubocop/rubocop#2218 on my local machine (which I hadn't seen before), so I upgraded to 0.35 to fix it. I originally went down the rathole of upgrading to the latest (0.39) but then I saw your PR which would make a gigantic mess so I reverted that.

@laramiel
Copy link
Contributor

LGTM.

@laramiel
Copy link
Contributor

Yeah, I see why 0.39 is not yet useful. For example, it now prefers raise to fail, etc.
I'll update to 0.39 once my next change is done.

@mr-salty mr-salty merged commit 3a580a5 into master Apr 12, 2016
@mr-salty
Copy link
Contributor Author

yeah, the biggest one is it wants 'freeze' on all constants, and we have a lot.

@mr-salty mr-salty deleted the rubocop35 branch April 19, 2016 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-salty @laramiel @googlebot